Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpg crypto backend very likely fails on json serialization #506

Open
clime opened this issue Feb 26, 2018 · 2 comments
Open

gpg crypto backend very likely fails on json serialization #506

clime opened this issue Feb 26, 2018 · 2 comments
Labels

Comments

@clime
Copy link

clime commented Feb 26, 2018

Hello, I think you should 'utf-8' decode the signature here:

https://github.com/fedora-infra/fedmsg/blob/develop/fedmsg/crypto/gpg.py#L177

@jeremycline
Copy link
Member

Hi,
That sounds reasonable (although 'ascii' would also work in this case). I'm curious about what prompted your investigation of the gpg backend? I really don't recommend using it. In fact, it really should be marked deprecated and removed.

@clime
Copy link
Author

clime commented Feb 27, 2018

Hello, I was debugging the same issue with x509 backend in python3-fedmsg-1.0.1 and stumbled upon this. Finally, I have found out I can just upgrade python3-fedmsg to version 1.1. and x509 works there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants