Skip to content
This repository has been archived by the owner on Sep 27, 2020. It is now read-only.

type: simplify Visitor definition #64

Open
yxliang01 opened this issue May 25, 2019 · 1 comment
Open

type: simplify Visitor definition #64

yxliang01 opened this issue May 25, 2019 · 1 comment

Comments

@yxliang01
Copy link
Contributor

The definition of Visitor interface is very long and error-prone that it might(or, have already) lost update with changes made on ASTNode. It's better to automatically generate at least some of the attribute of the Visitor interface if possible. Currently, I can't think of a solution yet. @Leeleo3x Maybe you have some idea?

@aoli-al
Copy link
Contributor

aoli-al commented May 26, 2019

It is true that maintaining the typings for a javascript library is tedious and error-prone. I don't know any good solution for this. Rewriting the whole project in Typescript could be a solution and you may want to check antlr4ts https://www.npmjs.com/package/antlr4ts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants