Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick README.md update #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lisa55asil
Copy link

links to other sections in part 1 songbird standalone do not work - so I just wrote in the section name they should check to be fool proof.

links to other sections in part 1 songbird standalone do not work - so I just wrote in the section name they should check to be fool proof.
@fedarko
Copy link
Owner

fedarko commented Sep 23, 2019

The links should start working when this is merged into the biocore/songbird repo, so I don't think this is a problem.

However, I do agree that the links should be a lot more foolproof than they are now. I'm going to see if I can use anchors to make more "stable" links.

@fedarko
Copy link
Owner

fedarko commented Sep 23, 2019

OK, I updated the links to use more stable anchors—so even if we mess around with the section titles, the links will stay the same. They're also "relative", so they'll work in fedarko/songbird, biocore/songbird, ... etc. e.g. https://github.com/fedarko/songbird#interpreting-model-fitting

@lisa55asil
Copy link
Author

Great! Maybe to increase the fool proofness you can have the link on text that describes where its going (i.e. 'section 4') instead of 'this link'

@fedarko
Copy link
Owner

fedarko commented Sep 23, 2019

oops I guess we commented at the same time, sorry... my opinion is to avoid specifying the section number in the text, since that can change. How about e.g. "this section on interpreting model fitting"? That way even if the link breaks (which it shouldn't, now) the reader will still have an idea of where to go

@lisa55asil
Copy link
Author

Ah right makes sense. OK that sounds good to me!

fedarko added a commit that referenced this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants