New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Check if pauseSerial() still gets called after duplicate STOP byte check #1

Open

featherbear opened this issue Aug 23, 2021 · 1 comment

Owner

featherbear commented Aug 23, 2021 •

edited

Loading

zifon-yt1000-wifi-acu/acu/http/src/PT.svelte

Lines 25 to 29 in a963886

  let _send = () => { 

  if (val == STOP_BYTE) { 

  if (lastSentWasStop) return; 

  lastSentWasStop = true; 

  } else lastSentWasStop = false;

Maybe send 2x STOP packets instead of 1, so the second stop packet causes

zifon-yt1000-wifi-acu/acu/wifi-acu/src/arduino-ptz/handler.cpp

Line 35 in a963886

pauseSerial();

to trigger

Owner Author

featherbear commented Aug 24, 2021

but tbh getSend() gets called a bunch of times and it will stop anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment