Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues using cargo vendor #552

Open
yu-re-ka opened this issue Jan 18, 2023 · 1 comment
Open

issues using cargo vendor #552

yu-re-ka opened this issue Jan 18, 2023 · 1 comment

Comments

@yu-re-ka
Copy link

yu-re-ka commented Jan 18, 2023

Description

Projects depending on feather can not vendor their dependencies using cargo vendor

Reproduction Steps

  1. git clone https://cyberchaos.dev/yuka/rnat
  2. cd rnat
  3. mkdir .cargo
  4. cargo vendor > .cargo/config.toml
  5. cargo build --all-features

What You Expected to Happen

The vendored versions of the feather crates should work standalone

What Actually Happened

libcraft-blocks-... attempts to load assets from outside its crate root, and fails to build

Screenshots and Logs

error: couldn't read /home/yuka/rnat/vendor/libcraft-blocks/src/../../assets/raw_block_states.bc.gz: No such file or directory (os error 2)
   --> /home/yuka/rnat/vendor/libcraft-blocks/src/registry.rs:216:36
    |
216 |         static STATE_DATA: &[u8] = include_bytes!("../../assets/raw_block_states.bc.gz");
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `include_bytes` (in Nightly builds, run with -Z macro-backtrace for more info)

error: couldn't read /home/yuka/rnat/vendor/libcraft-blocks/src/../../assets/raw_block_properties.bc.gz: No such file or directory (os error 2)
   --> /home/yuka/rnat/vendor/libcraft-blocks/src/registry.rs:222:39
    |
222 |         static PROPERTY_DATA: &[u8] = include_bytes!("../../assets/raw_block_properties.bc.gz");
    |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this error originates in the macro `include_bytes` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `libcraft-blocks` due to 2 previous errors

Your Environment

  • Operating System: Linux
  • Operating System Version: ...
  • Feather Version: a86d61d

Additional Context

It is a known bug in cargo that workspace git dependencies have issues with vendoring:

rust-lang/cargo#8885
rust-lang/cargo#11192

@Bloeckchengrafik
Copy link

Like abzh423 said in #550

It's dead I would say. No documentation, no clear structure. Start something on your own, would be much better, but this time make some nice ass documentation along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants