You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Modify the github workflow, such that it checks the server successfully starts when doing cargo run. Recently we had to revert a pull request. It could probably have been prevented if we had this.
Describe the solution you'd like
I don't know how we would check for a successfully start, but we could potentially use grep and search for the first occurrence of
the startup message. Optionally we just run the server for 60 sec.
The text was updated successfully, but these errors were encountered:
This would require some --dry-run, but I suggest we just start a server in one of the test, which connects to a fake TCP port (tokio testing) throw a few packets at the server and compare against some expected packets.
In the case of Datapacks, the code can be tested as well (fs operations can be tested... might not be ideal).
Feature Request
Modify the github workflow, such that it checks the server successfully starts when doing cargo run. Recently we had to revert a pull request. It could probably have been prevented if we had this.
Describe the solution you'd like
I don't know how we would check for a successfully start, but we could potentially use grep and search for the first occurrence of
the startup message. Optionally we just run the server for 60 sec.
The text was updated successfully, but these errors were encountered: