-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to disable <small>(emoji description)</small> text in fuzzel... #209
Comments
If If that's out of scope for them, I'll have to see if there's another good solution... it's very helpful for |
That's unfortunate. I will try to look at the code too and see if I am able to come up with any solutions. Thanks for your input. |
Having copies of data files without the markup is a possibility? |
Naively try to remove formatting tags for selectors that don't support it. Issue: #209
Theoretically yes, but that would duplicate some of them, leading to an even larger size of the package 😕 Instead, I've tried to very naively strip the tags. Could you please try the branch |
Running Is the performance difference negligible on your side? |
Is a few megabytes extra in package size not okay in case it gives significant speedup? We can also make it so that the stripped data files are statically generated after download as part of installation instead of packaging them. |
Ideally, we'd have both performance and small package size 😉 But as always, we have to choose between good things. If the performance with
I ran no extensive tests, but it felt good enough to me. Just wanted to make sure that that is not a fluke.
All the data files are currently packaged and not downloaded on demand. I find this is a nicer UX when everything just works. |
I meant the duplicate data files with tags removed will be generated from the data files with tags as a new package installation step after the single download, e.g. as with an But I think we won't need this as the performance is pretty similar doing it on the fly as well. Maybe the release build of rofimoji will differ in performance? I will try it later and let you know. I can open a PR for the extra installation step solution if you want to go ahead with that. |
I just tried with |
This also impacts |
Naively try to remove formatting tags for selectors that don't support it. Issue: #209
I've pushed the workaround to |
Does it remove the markup for all selectors including rofi? |
No, |
Thanks! Closing as resolved. |
...or make fuzzel render it properly instead of just displaying the markup tags?
The text was updated successfully, but these errors were encountered: