-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(packit): add pre-sync to fix propose-downstream action #695
Conversation
02cdffe
to
9e74c0e
Compare
9668b94
to
a200291
Compare
b7f4c10
to
a3a0bae
Compare
a3a0bae
to
dcf373f
Compare
Fedora's MRs are green as well |
Signed-off-by: Antonio Murdaca <[email protected]>
dcf373f
to
0222683
Compare
rebased to latest main - not sure what @nullr0ute meant with "incorrect changes" here #695 (comment) but this is very good to go finally (and automation works 🕺 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can take this opportunity to also include downstream updates for at least c10s now that it's supported? https://packit.dev/docs/configuration/upstream/propose_downstream#syncing-the-release-to-centos-stream
I honestly would get this done for 0.5.1 as it's been going out of scope from the original bug 😄 but we can tackle that immediately next to this :) |
scratch that, I made it work :) pushing! |
Signed-off-by: Antonio Murdaca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
fixed packit configuration to allow to build the vendor archive in propose downstream too - as it's bad to add conditionals around sources anyway https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_do_not_conditionalize_sources
So, if we want just one shared specfile, this is the way :mandalorian: