enhance onboarding testing #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmartinv
commented
Oct 7, 2024
•
mmartinv
commented
- chore: Move SELinux fixes to plan preparation steps
- fix(shellcheck): fix shellcheck lint issues
- chore: use a more meaningful name for generate_keys function
- test: simplify the code checking FDO services
- test: increase verbosity for FDO clients
- tests: add service infos to onboarding tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
3 times, most recently
from
c0198be to
ed5fe19
Compare
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
from
ed5fe19 to
6acff50
Compare
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
from
6acff50 to
1dc8fbd
Compare
|
something's going on with installing yq it seems |
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
2 times, most recently
from
bfcb54b to
7b781e6
Compare
Add the missing SELinux permissions to the plan preparation steps instead of fixing them in each test. Signed-off-by: Miguel Martín <[email protected]>
Signed-off-by: Miguel Martín <[email protected]>
Rename 'generate_keys' to 'generate_fdo_certificates' to describe better its purpose. Signed-off-by: Miguel Martín <[email protected]>
Simplify the code checking the FDO servers availability Signed-off-by: Miguel Martín <[email protected]>
Use "trace" as the LOG_LEVEL for the manufacturing and onboarding clients Signed-off-by: Miguel Martín <[email protected]>
Test actual service infos in onboarding tests to make sure the onboarding client has the needed SELinux permissions. Resolves: THEEDGE-3953 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
from
7b781e6 to
ecf498d
Compare
runcom
previously approved these changes
Oct 11, 2024
Remove Fedora ELN from the build as the compose is not present in Testing Farm and we cannot test them. Signed-off-by: Miguel Martín <[email protected]>
mmartinv
force-pushed
the
enhance-onboarding-testing
branch
from
e071115 to
359ea48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.