fix(data-formats): use serde_tuple serializer for error messages #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we add some integration tests to check that the |
mmartinv
force-pushed
the
fix-cbor-error-serialization
branch
from
8bb1e0c to
e488946
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mmartinv
force-pushed
the
fix-cbor-error-serialization
branch
from
e488946 to
33f03d2
Compare
mmartinv
changed the title
serde_tuple serializer for Error messages
mmartinv
changed the title
serde_tuple serializer for Error messages
mmartinv
changed the title
mmartinv
changed the title
Use `serde_tuple` to serialize/deserialize the error messages as a CBOR arrays instead of a CBOR maps as described in the FIDO Device Onboard Specification. Fixes: fdo-rs#620 Signed-off-by: Miguel Martín <[email protected]>
mmartinv
force-pushed
the
fix-cbor-error-serialization
branch
from
33f03d2 to
d3d65d6
Compare
|
I've merged this one manually since mergify did not kick in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
serde_tupleto serialize/deserialize the error messagesas a CBOR arrays instead of a CBOR maps as described in the
FIDO Device Onboard Specification.
Fixes: #620
Signed-off-by: Miguel Martín [email protected]