Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current date in filter change when clicking on it #58

Open
panthony opened this issue Apr 9, 2015 · 0 comments
Open

Current date in filter change when clicking on it #58

panthony opened this issue Apr 9, 2015 · 0 comments

Comments

@panthony
Copy link
Contributor

panthony commented Apr 9, 2015

How to reproduce:

  • Select "Last hour"
    • Click in the "from time" input

The scale will change to "Manual" (expected) but the from date will change to the T-24h, it should not !
panthony added a commit to panthony/jrds that referenced this issue Apr 11, 2015
@panthony
Fix time period filter where date would change when focused (fbacchel…
f58dce4 
…la#58)

When focusing a date or time input, we automatically set the  autoperiod to '0' (meaning manual) but the comparison in 'onChange' callback would always fails and always update the input to the latest value.

The comparison fails because 'value' is a string and '!==' means a strict equality of both value and type.
fbacchella pushed a commit that referenced this issue Apr 24, 2015
@panthony @fbacchella
Fix time period filter where date would change when focused (#58)
6a7fcd0 
When focusing a date or time input, we automatically set the  autoperiod to '0' (meaning manual) but the comparison in 'onChange' callback would always fails and always update the input to the latest value.

The comparison fails because 'value' is a string and '!==' means a strict equality of both value and type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@panthony