Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto content-length setting #884

Open
guybedford opened this issue Aug 2, 2024 · 0 comments
Open

Auto content-length setting #884

guybedford opened this issue Aug 2, 2024 · 0 comments

Comments

@guybedford
Copy link
Member

guybedford commented Aug 2, 2024

We currently set content-type automatically during extract_body which is called in the request and response constructors.

According to the fetch spec, content-length is supposed to be set when initiating the request, , see here - https://fetch.spec.whatwg.org/#http-network-or-cache-fetch.

StarlingMonkey recently started setting content-length and content-type in this position, but I believe this is a bug as content-length should only be sent when initiating the response.

Should we be setting content-length further, or does XQD effectively handle this for us entirely?

Corrected from original post after verifying content-type is certainly being set correctly.

@guybedford guybedford changed the title content-length and content-type Auto content-type setting Aug 2, 2024
@guybedford guybedford changed the title Auto content-type setting Auto content-length and content-type setting Aug 2, 2024
@guybedford guybedford changed the title Auto content-length and content-type setting Auto content-length setting Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant