From 0167a61e573f3d6b595855e606a0553ffbefecc1 Mon Sep 17 00:00:00 2001 From: Felix Krause Date: Mon, 5 Oct 2015 21:47:11 -0400 Subject: [PATCH] Improved code style --- .rubocop_general.yml | 9 +++++---- lib/deliver/upload_metadata.rb | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.rubocop_general.yml b/.rubocop_general.yml index 4283c8c..fee75a1 100644 --- a/.rubocop_general.yml +++ b/.rubocop_general.yml @@ -51,6 +51,11 @@ Metrics/MethodLength: Exclude: - 'lib/*/options.rb' +Metrics/AbcSize: + Max: 60 + Exclude: + - 'lib/*/options.rb' + # Both string notations are okay Style/StringLiterals: Enabled: false @@ -83,10 +88,6 @@ Style/AlignHash: Style/AndOr: Enabled: false -# Offense count: 20 -Metrics/AbcSize: - Max: 60 - # Configuration parameters: CountComments. Metrics/ClassLength: Max: 320 diff --git a/lib/deliver/upload_metadata.rb b/lib/deliver/upload_metadata.rb index d82e89c..5adb285 100644 --- a/lib/deliver/upload_metadata.rb +++ b/lib/deliver/upload_metadata.rb @@ -12,9 +12,9 @@ class UploadMetadata # Non localized app details values NON_LOCALISED_APP_VALUES = [:primary_category, :secondary_category, - :primary_first_sub_category, :primary_second_sub_category, - :secondary_first_sub_category, :secondary_first_sub_category - ] + :primary_first_sub_category, :primary_second_sub_category, + :secondary_first_sub_category, :secondary_first_sub_category + ] # Make sure to call `load_from_filesystem` before calling upload def upload(options)