fix: allow for getUpstream flow for empty wsUpstream option #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #333
This fix makes using
wsUpstream: ''
with a setreplyOptions.getUpstream
consistent with the established flow of usingupstream: ''
with agetUpstream
set. To do so, just some added logic to the plugin initialization phase as well as updating the WebsocketProxy constructor logic. Note, I maintained the need for thewebsocket
flag needing to be set totrue
to remain consistent with the proxying of websockets currently.This should also allow for dynamically setting a websocket upstream through the use of the websocket options provided, which should be a bit more clear for those wanting that behavior.
Checklist
npm run test
andnpm run benchmark
and the Code of conduct