Update README.md #381
Open
Update README.md #381
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated README.md to show Fastify version bump Signed-off-by: Cody Wolter <[email protected]>
2 tasks
2 tasks
Eomm
reviewed
Oct 25, 2024
| @@ -15,8 +15,8 @@ This plugin can be used in a variety of circumstances, for example if you have t | |||
|
|
|||
| ## Requirements | |||
|
|
|||
| Fastify 4.x. | |||
| See [@fastify/http-proxy v7.x](https://github.com/fastify/fastify-http-proxy/tree/v7.x) for Fastify 3.x compatibility. | |||
| Fastify 5.x. | |||
There was a problem hiding this comment.
I think this approach is more readable:
https://github.com/Eomm/fastify-raw-body?tab=readme-ov-file#compatibility
WDYT?
There was a problem hiding this comment.
I don't disagree, I just wanted to follow the existing format to stay within scope of the issue I created. Rather than start to reformat how the compatibility is shown.
But I do like this approach, rather than clicking (potentially several times) to find the plugin version that's compatible with a specific Fastify version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README.md to show Fastify version bump
Checklist
npm run testandnpm run benchmarkand the Code of conduct