Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate layout components and core design tokens. #407

Closed
jgaehring opened this issue Sep 5, 2020 · 3 comments
Closed

Integrate layout components and core design tokens. #407

jgaehring opened this issue Sep 5, 2020 · 3 comments

Comments

@jgaehring
Copy link
Member

As a first step towards removing Bootstrap entirely, I want to remove all Bootstrap layout classes (container-fluid etc) with custom layout components based on the Braid Design System.

@jgaehring
Copy link
Member Author

Apart from replacing the Bootstrap row's and container's in the screen-level components like EditLog, I think it will be important to make sure all my content components area also using Braid-based layout components so that responsive props and design tokens can be consistently passed down to the children components seamlessly. It may be helpful to implement a FarmBox component, similar to Braid's Box, as a primitive and use it across all components, including in FarmInline and FarmStack.

@jgaehring jgaehring changed the title Replace Bootstrap layout classes with custom layout components. Integrate layout components and core design tokens. Sep 12, 2020
@jgaehring
Copy link
Member Author

I think the best way to start on this is to replace all the Bootstrap styles in the AllLogs component. Might want to rename that component, too, while I'm at it.

@jgaehring
Copy link
Member Author

Layout components are all finally integrated into TasksAll (formerly AllLogs) and all the core components, such as Home, Login, etc. The design tokens have also been integrated into all those components, plus the layout components themselves. All layout components have been documented in Storybook. The only thing left is to remove Bootstrap classes from TasksEdit, which will be done when I overhaul that design in #408. So I'm closing this so I can begin that tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant