Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

[request] Show stat distribution in power up menu #1022

Open
udnp opened this issue Dec 9, 2018 · 8 comments
Open

[request] Show stat distribution in power up menu #1022

udnp opened this issue Dec 9, 2018 · 8 comments

Comments

@udnp
Copy link
Contributor

udnp commented Dec 9, 2018

User request
https://www.reddit.com/r/GoIV/comments/a3wc8n/request_show_stat_distribution_in_power_up_menu/

My private custom build for GoIV v4.3.3
device-2018-12-07-150002

It should be better to be adapted to v5 UI.

@AbcentMineDead
Copy link

AbcentMineDead commented Dec 10, 2018

Curious if this implementation is just showing base stats + IV or if it has the potential to be more detailed?

This is an image I grabbed to show an example of what I'm talking about. http://imgur.com/a/o5YmNgV

Note: I don't know why or where these numbers come from exactly but maybe you can steer me clear.

@udnp
Copy link
Contributor Author

udnp commented Dec 11, 2018

Curious if this implementation is just showing base stats + IV or if it has the potential to be more detailed?

My picture is just on base stats not including IV.
and I think so for this users request, currently.

This is an image I grabbed to show an example of what I'm talking about. http://imgur.com/a/o5YmNgV

Are your pictures from Calcy IV app?

@AbcentMineDead
Copy link

Yes my image is from calcy IV. I apologise but I'm very interested in why the "base stats" have such a disparity that I don't understand from the calcy IV power up page.

Is a L1 Bulbasaur's base stats:
ATK 118 + IV
DEF 111 + IV
STA 128 + IV

Is a L40 Bulbasaur's base stats:
ATK 118 + IV
DEF 111 + IV
STA 128 + IV

Or do they increase in some way I don't understand as they are powered up? It seems they do. Sorry I'm just genuinely curious.

Cheers!! I only use GoIV for my scans but I do like to peek around the other options. I've used GoIV since the author publicly made it available. =)

<3 <3 <3

@AbcentMineDead
Copy link

Something called CP mulitplier or CP*ML. I'm just trying to help.

@udnp
Copy link
Contributor Author

udnp commented Dec 15, 2018

Is a L1 Bulbasaur's base stats:
ATK 118 + IV
DEF 111 + IV
STA 128 + IV

Is a L40 Bulbasaur's base stats:
ATK 118 + IV
DEF 111 + IV
STA 128 + IV

My understanding is the same.
When a pokemon becomes level up, its ability of attack, defense, and stamina increase.
But its base stats do not change, I think.

Or do they increase in some way I don't understand as they are powered up? It seems they do. Sorry I'm just genuinely curious.

They may know the logic to add a pokemon's increased abilities to its stats and to show them.
If we could know that logic, we would have possibility to implement it to GoIV...

@AbcentMineDead
Copy link

Well that explains that! I'll dig around and see if I can find that logic publicly listed. To be blunt I'd love the base stats to show just as you showed. I enjoy doing a little bit of guessing and studying with out a certainty. If I really really need to know how/what a Pokemon will be doing I export to PB and sim.

I'm newer to GitHub and how to use it correctly. How do I obtain your version and is it up to date with stats but not UI? Sorry if I'm understanding wrong.

@udnp
Copy link
Contributor Author

udnp commented Dec 16, 2018

thanks for your interest in my impl.
i have not pushed that to github my GoIV🇯🇵 repo yet.

sorry today is a Japaese party 忘年会 for Ingress players.
so next day i will publish my patch for this impl.

@udnp
Copy link
Contributor Author

udnp commented Dec 17, 2018

This is my experimental patch for GoIV_JP.
But you know, my GoIV_JP is based on official GoIV v4.3.3.
So I think it needs to be adapted and improved for official GoIV v5, especially changes of expanded_results_box.xml.

diff --git app/src/main/java/com/kamron/pogoiv/Pokefly.java app/src/main/java/com/kamron/pogoiv/Pokefly.java
index 70bbb462..a08b1de2 100644
--- app/src/main/java/com/kamron/pogoiv/Pokefly.java
+++ app/src/main/java/com/kamron/pogoiv/Pokefly.java
@@ -214,6 +214,13 @@ public class Pokefly extends Service {
     // Result data
     private PokemonSpinnerAdapter extendedEvolutionSpinnerAdapter;
 
+    @BindView(R.id.baseStatAtk)
+    TextView baseStatAtk;
+    @BindView(R.id.baseStatDef)
+    TextView baseStatDef;
+    @BindView(R.id.baseStatSta)
+    TextView baseStatSta;
+
     @BindView(R.id.extendedEvolutionSpinner)
     Spinner extendedEvolutionSpinner;
 
@@ -1461,6 +1468,9 @@ public class Pokefly extends Service {
         exResLevel.setText(String.valueOf(selectedLevel));
         setEstimateLevelTextColor(selectedLevel);
 
+        //setBaseStat(ivScanResult.pokemon); // for the scanned pokemon
+        setBaseStat(selectedPokemon); // for the selected pokemon
+
         setAndCalculatePokeSpamText(ivScanResult);
     }
 
@@ -1505,6 +1515,12 @@ public class Pokefly extends Service {
         exResultHP.setText(hpText);
     }
 
+    private void setBaseStat(Pokemon pokemon) {
+        baseStatAtk.setText(String.valueOf(pokemon.baseAttack));
+        baseStatDef.setText(String.valueOf(pokemon.baseDefense));
+        baseStatSta.setText(String.valueOf(pokemon.baseStamina));
+    }
+
     /**
      * setAndCalculatePokeSpamText sets pokespamtext and makes it visible.
      *
diff --git app/src/main/res/layout/expanded_results_box.xml app/src/main/res/layout/expanded_results_box.xml
index a18888ed..f1bd6bfd 100644
--- app/src/main/res/layout/expanded_results_box.xml
+++ app/src/main/res/layout/expanded_results_box.xml
@@ -64,6 +64,93 @@
 
     </LinearLayout>
 
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal">
+
+        <TextView
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="start"
+            android:text="@string/atk"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+        <View
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            android:layout_weight="1"/>
+
+        <TextView
+            android:id="@+id/baseStatAtk"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            tools:text="#ofStatATK"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+    </LinearLayout>
+
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal">
+
+        <TextView
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="start"
+            android:text="@string/def"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+        <View
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            android:layout_weight="1"/>
+
+        <TextView
+            android:id="@+id/baseStatDef"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            tools:text="ofStatDEF"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+    </LinearLayout>
+
+    <LinearLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal">
+
+        <TextView
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="start"
+            android:text="@string/sta"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+        <View
+            android:layout_width="0dp"
+            android:layout_height="0dp"
+            android:layout_weight="1"/>
+
+        <TextView
+            android:id="@+id/baseStatSta"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="end"
+            tools:text="#ofStatSTA"
+            android:textColor="@color/importantText"
+            android:textSize="@dimen/resultExpandedTextSize"/>
+
+    </LinearLayout>
+
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants