Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not compatible with Wagmi persistence with cookies #407

Open
0x3dev opened this issue Jul 6, 2024 · 8 comments
Open

[BUG] Not compatible with Wagmi persistence with cookies #407

0x3dev opened this issue Jul 6, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@0x3dev
Copy link

0x3dev commented Jul 6, 2024

Describe the bug

When trying to implement the steps outlined in Wagmi SSR page, specifically Persistence using Cookies, NextJS throws this error:

Error: (0 , react__WEBPACK_IMPORTED_MODULE_0__.createContext) is not a function
eval node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/framer-motion/dist/es/context/LazyContext.mjs (3:32) (rsc)/./node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/framer-motion/dist/es/context/LazyContext.mjs

To reproduce

Create a new project with npm create wagmi --template next and add connectkit to it. The error will show at first run.

Additional context

If we don't pass the initialState like this,
const initialState = cookieToInitialState( getConfig(), headers().get("cookie") );

The error is gone, so it seems the method getDefaultConfig from connectkit doesn't support SSR.

@0x3dev 0x3dev added the bug Something isn't working label Jul 6, 2024
@sazzouz
Copy link

sazzouz commented Jul 7, 2024

I have run into the same issue after attempting to implement the SSR guide on the wagmi docs. I came looking for this after noticing a recurring issue whereby the current wallet seems to persist after calling disconnect() with the UI or wagmi, leading to a Metamask error when you try to connect the same or another wallet again. Only when the page is fully refreshed can you connect again. I assumed this issue lies in some incomplete configuration for Next.js, which is why i have added this here to the SSR implementation issues.

This is currently observable in your docs too here. You can follow these steps to reproduce: (1) Connect with MM (2) Disconnect (without page refresh) (3) Connect again with MM (4) MM error (5) Refresh page and connect with MM succeeds.

See demo below:

Screen.Recording.2024-07-07.at.22.34.59.mov

@seeARMS
Copy link

seeARMS commented Aug 13, 2024

Confirming I'm having the same issue.

@BenraouaneSoufiane
Copy link

Confirming I'm having the same issue.

Hello, you need to add 'use client' at the top of your page (where connectKit is included/imported) as shown below

pr1
pr2

I'm waiting you to pay the bounty please, here's my address: 0xBbA4Ef1F2749Bb679e35c357D26217761a061B73, thank you

@sahilkakwani9
Copy link

Hello @0x3dev!

After investigating, it appears that this error is related to framer-motion, a dependency of ConnectKit. Even though getDefaultConfig itself doesn't directly use framer-motion, importing from ConnectKit causes framer-motion to be initialized in a server context where it's not compatible.

Interestingly, when I create a local version of getDefaultConfig that doesn't import from ConnectKit, the error doesn't occur. This suggests that the issue is specifically related to how ConnectKit's dependencies are being loaded or initialized in an SSR context.

Below is the code that is server-side rendered and causing the issue:

const initialState = cookieToInitialState(
  getConfig(),
  headers().get("cookie")
);

Some Workarounds

  1. Pass a normal config created through createConfig imported from wagmi into this server-rendered code and use a ConnectKit default config in WagmiProvider.
export function getConfig() {
  const config = createConfig(
    getDefaultConfig({
      // Your dApp's chains
      chains: [mainnet],
      transports: {
        // RPC URL for each chain
        [mainnet.id]: http(
          `https://eth-mainnet.g.alchemy.com/v2/${process.env.NEXT_PUBLIC_ALCHEMY_ID}`
        ),
      },

      // Required API Keys
      walletConnectProjectId: "WalletConnect Project Id",

      // Required App Info
      appName: "Your App Name",

      // Optional App Info
      appDescription: "Your App Description",
      appUrl: "https://family.co", // your app's url
      appIcon: "https://family.co/logo.png", // your app's icon, no bigger than 1024x1024px (max. 1MB)
      ssr: true,
      storage: createStorage({
        storage: cookieStorage,
      }),
    })
  );

  return config;
}

export function getWagmiConfig() {
  return createConfig({
    chains: [mainnet],
    ssr: true,
    storage: createStorage({
      storage: cookieStorage,
    }),
    transports: {
      [mainnet.id]: http(),
    },
  });
}
  1. Implement the getDefaultConfig method locally. Refer to this example.

@lochie
Copy link
Member

lochie commented Aug 17, 2024

Wow nice discovery @sahilkakwani9! Thanks for investigating this, definitely weird that framer-motion is causing this issue.

We've internally discussed removing framer-motion now that view transitions and other similar tech are now more widely supported. Might be ideal for us to fast track that update now knowing this is an issue 🤔

@BenraouaneSoufiane
Copy link

BenraouaneSoufiane commented Aug 17, 2024

It not depends on the connectKit even on the wagmi, it depends on the framework, how to get rendered, it's not a bug
@seeARMS although you've marked the bounty as completed, nothing received

@seeARMS
Copy link

seeARMS commented Sep 30, 2024

Just wanted to flag that I finally got around to implementing @sahilkakwani9's workaround. It works great and removes the exception thrown in the OP, but unfortunately it also prevents users from using the MetaMask Chrome extension -- it always prompts them to use their phone to sign in with Metamask. Setting ssr: false with no other changes fixes this.

Presumably there's an issue with extension detection when it's first server-rendered?

@ArmmGh
Copy link

ArmmGh commented Nov 8, 2024

hi, @sahilkakwani9 thanks a lot for workaround with cookies storage, but I'd like to ask something, do you still have an issue to see empty space instead of wallet account when you refresh the page. with only Wagmi it worked well but when I added connectKit and using your workaround now it blinks on refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants