Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falco Rules Doc Comments #150

Open
leogr opened this issue Sep 4, 2023 · 11 comments
Open

Falco Rules Doc Comments #150

leogr opened this issue Sep 4, 2023 · 11 comments
Labels
help wanted Extra attention is needed kind/feature New feature or request

Comments

@leogr
Copy link
Member

leogr commented Sep 4, 2023

Motivation

The issues I found with comments are due to practical reasons. In particular:

  • There should be no empty lines between the comments and the referred item
    • This will avoid ambiguities.
    • I guess I mostly fixed that with this PR.
  • There's no standard item's comment structure
    • I would love to define a simple Rule Doc convention (i.e., something similar to Go Doc Comments, but simpler)
  • There's no clear way to distinguish sections from item's comment

Feature

Implement a simple Rules Doc Comments guideline and add it to the rules style guide.

Alternatives

Just rely on an existing convention, if any, or do nothing. However they don't look like compelling alternatives.

Additional context

See #149 (comment)

@leogr leogr added the kind/feature New feature or request label Sep 4, 2023
@poiana
Copy link

poiana commented Dec 3, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Dec 5, 2023

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Dec 5, 2023

@incertum do you think this is still valuable? wdyt?

cc @LucaGuerra

@poiana
Copy link

poiana commented Mar 4, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@incertum
Copy link
Contributor

incertum commented Mar 5, 2024

still relevant

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Mar 5, 2024

cc @falcosecurity/falco-website-maintainers

@poiana
Copy link

poiana commented Jun 3, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Jun 4, 2024

This is still a thing, IMO.

cc @falcosecurity/rules-maintainers
/help
/lifecycle stale

@poiana
Copy link

poiana commented Jun 4, 2024

@leogr:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This is still a thing, IMO.

cc @falcosecurity/rules-maintainers
/help
/lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana added the help wanted Extra attention is needed label Jun 4, 2024
@poiana
Copy link

poiana commented Jul 4, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@leogr
Copy link
Member Author

leogr commented Jul 18, 2024

/remove-lifecycle rotten
/remove-lifecycle stale

@LucaGuerra @Issif May you help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants