Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] add note styles for all theme states #39

Open
cylewitruk opened this issue Apr 12, 2024 · 2 comments
Open

[improvement] add note styles for all theme states #39

cylewitruk opened this issue Apr 12, 2024 · 2 comments

Comments

@cylewitruk
Copy link
Contributor

cylewitruk commented Apr 12, 2024

Today note uses the success state (green diamond). We should also support the other states such as warning, info, error, etc.

For example, in the following I would have preferred to have used a note_info():
image

P.S. I think I would have preferred to "replace" the Generate new keychain spinner (it takes ~3-4 secs) with a success note -- not sure if I can do this today? Something like spinner.stop_with_note(ThemeState::Success, "✔ Generate new keychain", "...");

@fadeevab
Copy link
Owner

@cylewitruk Hm, not sure if it would work but you could try calling spinner.clear without stopping, and then note().

@cylewitruk
Copy link
Contributor Author

@cylewitruk Hm, not sure if it would work but you could try calling spinner.clear without stopping, and then note().

Afk now but i'll try it -- iirc though the clear only clears the line and doesn't remove it though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants