Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for confirm #41

Open
IgalOre opened this issue Jul 9, 2015 · 4 comments
Open

Replacement for confirm #41

IgalOre opened this issue Jul 9, 2015 · 4 comments

Comments

@IgalOre
Copy link

IgalOre commented Jul 9, 2015

Hello, i had discovered angular-unsavedChanges project throw Googling, and so far everything looking good and promising. So far i got 2 questions:

  1. Is there any specific reason why this project not published on NPMJS ? (except of capital letter in name) ?

  2. If you would be required to replace windows.confirm with alternative dialog pop-up as one from angular UI-Bootstrap modal pop-up http://angular-ui.github.io/bootstrap/#/modal , how would you do so ?

Thank you in advance ...

@cstephe
Copy link

cstephe commented Jul 9, 2015

as for your second question, I had to fork it in order to customize dialog behavior. custom modals are non blocking unlike confirm, so it is not a trivial thing. if it helps here is my commit history on my fork:
https://github.com/cstephe/angular-unsavedChanges/commits/cniUpdates

@IgalOre
Copy link
Author

IgalOre commented Jul 10, 2015

It does helps, thank you Chris; it would spare few code tinkering ...

@menelaosbgr
Copy link

cstephe, I see you have made changes to your repo but have you uploaded a full demo showing the custom dialog functionality???

@cstephe
Copy link

cstephe commented Dec 2, 2015

@menelaosbgr nope I'm not PRing it, If you want to go ahead, but it needs work to be an universal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants