Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower.json incorrect main path #39

Open
sabrehagen opened this issue May 16, 2015 · 9 comments
Open

bower.json incorrect main path #39

sabrehagen opened this issue May 16, 2015 · 9 comments

Comments

@sabrehagen
Copy link

The main property in your bower.json incorrectly refers to unsavedChanges.js rather than dist/unsavedChanges.js. This breaks tools like wiredep. Can you please update your main path to reflect the correct path to the source?

@adamkarb
Copy link

@sabrehagen same problem here. Do you know any way to fix that?

@sabrehagen
Copy link
Author

I have been manually editing my local copy of the repo, but it needs to be done every time you do a fresh bower install which is annoying. We could submit a pull request, but there are outstanding pull requests that have already been waiting for months, so the likelihood of it getting accepted is low. You could always fork your own copy, edit it there, and bower install from your repo; that's the best solution.

@adamkarb
Copy link

Yea that sounds fair, but I will probably just do something on my own. This guy seems to have skipped town.

@sabrehagen
Copy link
Author

This seems to be fixed in your repository. Can you please publish it to npm?

@Stargator
Copy link

@sabrehagen Could you go ahead and do a pull request just so others that see it may find it useful to merge into their own repos.

Additionally, I would recommend mentioning facultymatt when creating issues and pull requests so he is sure to be notified.

@adamkarb
Copy link

adamkarb commented Nov 4, 2015

Another fix is to use wiredep's "overrides" property to set the correct path for the bower.json "main".

@sabrehagen
Copy link
Author

@Stargator it's fixed in this repo, so if you clone the repo it will work, but (presumably) we're all using npm where the package hasn't been updated with the latest source from the repo.

@vbullinger
Copy link

I'm just using bower and it still has this problem. Does anybody have a working fork? I mean, it works on my machine, but if I commit this code, it will break everyone on the team's app, as well as the development server...

EDIT: Hey, got it! Just specify a version in the command line. The latest version, as of this comment, is 0.2.3-alpha.3. So I just said this at the command line:

bower install angular-unsavedChanges#0.2.3-alpha.3 --save

@sabrehagen
Copy link
Author

Use the github repo in your bower file as the repo has the correct path, what's installed by bower is out of date.
On 22 Mar 2016 8:22 am, Vince Bullinger [email protected] wrote:I'm just using bower and it still has this problem. Does anybody have a working fork?

—You are receiving this because you were mentioned.Reply to this email directly or view it on GitHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants