Updates to Hip.cmake to support recent ROCm #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pruthvistony
commented
Oct 6, 2023
pruthvistony
commented
- Remove deprecated HIP_PATH
- Cleanup of unused variables
- Remove deprecated HIP_PATH - Cleanup of unused variables
|
Looks like CI failed? |
malfet
approved these changes
Oct 10, 2023
|
@fduwjj |
|
@fduwjj CI has been broken for a year or so. Changes proposed here are noop for existing CI. I.e. CI is failing with: And indeed, this container does not exist for 6+ month |
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@malfet , |
|
@malfet if so, shall we remove that test from CI? |
lisaong
pushed a commit
to lisaong/gloo
that referenced
this pull request
Feb 19, 2024
Summary: - Remove deprecated HIP_PATH - Cleanup of unused variables Pull Request resolved: facebookincubator#371 Reviewed By: kit1980 Differential Revision: D50140546 Pulled By: malfet fbshipit-source-id: 004bca04ba415df37c181652dfcd4e36353d769d
pruthvistony
added a commit
to ROCm/gloo
that referenced
this pull request
Mar 8, 2024
Summary: - Remove deprecated HIP_PATH - Cleanup of unused variables Pull Request resolved: facebookincubator#371 Reviewed By: kit1980 Differential Revision: D50140546 Pulled By: malfet fbshipit-source-id: 004bca04ba415df37c181652dfcd4e36353d769d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.