Fixed the bug in gatherv #347
Conversation
|
Hi @WanXiaopei! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
I do not know why |
make installGLOO_ENFORCE_GEis a wrong check, for example: there are two tasks, A task send 3 and 4 elements to task A and task B, respectively, while task B send 5 and 6 elements to task A and task B, respectively. In this way, theopts.elementsPerRankof task A will be 3 and 5, apparently, 4 (the number of elements send to task B) is not greater equal than 5 (the number of elements receive from task B).一. gatherv.h在执行make install 时并没有拷贝到对应的目录，导致不能使用
二. 在gloo/gatherv.cc的107行和108行中，GLOO_ENFORCE_GE在这里的校验是错误的。比如，如果有两个任务，任务A分别向任务A和任务B发送3和4个数据，任务B分别向任务A和任务B发送5个和6个数据。那么对于任务A，则其opts.elementsPerRank将会是3和5，显然4（发送给任务B的数据量）并不是大于等于5（从任务B中收到的数据量）的。