From a2ef36bd337df0109fe962ccd78f7528449ad425 Mon Sep 17 00:00:00 2001
From: Richard Barnes <rbarnes@meta.com>
Date: Tue, 23 Jan 2024 12:44:41 -0800
Subject: [PATCH] Fix compiler warning issues in fizz/server/ServerProtocol.cpp

Summary:
This diff fixes issues identified by one or more of these compiler warning flags:
* `-Wpessimizing-move`
* `-Wmissing-braces `
* `-Wself-assign`
* `-Wunused-lambda-capture `
* `-Wheader-hygiene`
* `-Wunused-variable`
* `-Wunused-parameter`
* `-Wsign-compare`

If the code compiles, it should work.

Reviewed By: dmm-fb

Differential Revision: D52970480

fbshipit-source-id: 172f2cfb79af4018444d379937682d9cbbfc402e
---
 fizz/server/ServerProtocol.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fizz/server/ServerProtocol.cpp b/fizz/server/ServerProtocol.cpp
index 5af0b635fee..5e36ab9eca3 100644
--- a/fizz/server/ServerProtocol.cpp
+++ b/fizz/server/ServerProtocol.cpp
@@ -690,7 +690,7 @@ static void validateGroups(const std::vector<KeyShareEntry>& client_shares) {
 }
 
 static std::tuple<NamedGroup, Optional<Buf>> negotiateGroup(
-    ProtocolVersion version,
+    ProtocolVersion /*version*/,
     const ClientHello& chlo,
     const std::vector<NamedGroup>& supportedGroups) {
   auto groups = getExtension<SupportedGroups>(chlo.extensions);
@@ -747,7 +747,7 @@ static HelloRetryRequest getHelloRetryRequest(
     CipherSuite cipher,
     NamedGroup group,
     Buf legacySessionId,
-    HandshakeContext& handshakeContext) {
+    HandshakeContext& /*handshakeContext*/) {
   HelloRetryRequest hrr;
   hrr.legacy_version = ProtocolVersion::tls_1_2;
   hrr.legacy_session_id_echo = std::move(legacySessionId);