Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

__evaluatePureFunction doesn't properly validate arguments #2385

Open
NTillmann opened this issue Aug 3, 2018 · 6 comments
Open

__evaluatePureFunction doesn't properly validate arguments #2385

NTillmann opened this issue Aug 3, 2018 · 6 comments

Comments

@NTillmann
Copy link
Contributor

Prepacking the following crashes Prepack.

__evaluatePureFunction("boo");

In the implementation, it shouldn't check via an invariant that the argument is a proper value, but instead it should throw a user-level exception or emit a CompilerDiagnostics error.

@rahilvora
Copy link

Hey @NTillmann I am very new to open source contribution and I would love to work on this issue. Should I go ahead with it?

@NTillmann
Copy link
Contributor Author

This one should be easy! Give it a try.

@rahilvora
Copy link

Sure. Will try it :)

@rahilvora
Copy link

PR for this issue: #2403

@rahilvora
Copy link

@NTillmann Can you please tell which error message I should add for this issues which will help a developer to understand the error https://github.com/facebook/prepack/wiki/Prepack-diagnostics

@NTillmann
Copy link
Contributor Author

Just make up a new PP number that isn't used yet. Propose a wiki text in your PR, and then we'll create the wiki page for you when landing the PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants