Too many bugs in composition mode

[szrenwei]

Do you want to request a feature or report a bug?

bug

What is the current behavior?

1. Input some chars use IME, then command + z to undo the chars, it will not work
2. Input two line text, select them all, use IME to input some chars, the second line would not be removed

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. You can use this jsfiddle to get started: https://jsfiddle.net/gmertk/e61z7nfa/.

Just go to the official site to try: https://draftjs.org/

What is the expected behavior?

1. undo should work when input use IME
2. use IME should replace all selected lines

Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?

version >= 0.11.0 all have these problems, I notice that you have changed the composition handler, that is the cause of these bugs.

like this: https://github.com/facebook/draft-js/blob/master/src/component/handlers/composition/DraftEditorCompositionHandler.js#L256, the author must be
drunk when he write the code, EditorState.push has push the same contentState, this line of code just useless.

[thibaudcolas]

Testing this briefly, it looks like it’s the first change to the editor that can’t be un-done:

I couldn’t reproduce the issue with replacing text, do you have more detailed steps @szrenwei?

[szrenwei]

@thibaudcolas

1. In fact, all your input use IME can't be undo, you can undo because you start a new block. ( the content add by IME just not been add to undo stack )

2. As blew, select all text and try to replace:
   

[thibaudcolas]

Thank you, that seems pretty clear-cut. Trying this again, I also managed to get the editor to crash (and the whole page, I imagine the demo doesn’t have any error handling).

[Marckon]

see this pomelovico/keep#30

[avatar0527]

see this pomelovico/keep#30

How/where would I implement this to get it to work? I'm still fairly new/learning but I feel like this might be just what I need!

[Marckon]

see this pomelovico/keep#30

How/where would I implement this to get it to work? I'm still fairly new/learning but I feel like this might be just what I need!

You just need to listen to comositionstart event when your editor mounted (like componentDidMount)

[avatar0527]

see this pomelovico/keep#30

How/where would I implement this to get it to work? I'm still fairly new/learning but I feel like this might be just what I need!

You just need to listen to comositionstart event when your editor mounted (like componentDidMount)

Thank you!

[psybor]

#3177