Incorrect cached child size is used because YGNodeCanUseCachedMeasurement() does not respect min/max dimensions #1003
Labels
Comments
|
thanks for pointing that out. I just pushed PR for a fix. |
|
I'm not sure if the PR will be merged, as it is a quite edge case here, which leads to increasing the binary size for each node. In that case I suggest, adding another root node, where you set height and width directly and pass Changing these values on that new root node lead to proper invalidation of the tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Report
Issues and Steps to Reproduce
See the attached example.
Child node has height = 10, minHeight = 40%, maxHeight = 60%.
When parent is measured against height = NaN, child height is computed to be 10, which is correct.
But then parent is laid out against height = 30.
Now child height should be
max(40% * 30, min(10, 60% * 30)) = max(12, min(10, 18)) = 12.But
YGNodeCanUseCachedMeasurement()returnstrueand cached height of 10 is used instead.Expected Behavior
In all the cases, final layout should have child height of 12.
Actual Behavior
In some of the scenarios incorrect cached height is used.
Link to Code
https://pastebin.com/x5e6ZL2b
The text was updated successfully, but these errors were encountered: