Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't hardcode loopback as ::1 in tests #192

Open
hjmallon opened this issue Apr 26, 2019 · 0 comments
Open

Don't hardcode loopback as ::1 in tests #192

hjmallon opened this issue Apr 26, 2019 · 0 comments

Comments

@hjmallon
Copy link
Contributor

The tests have ::1 hardcoded as the loopback address. This is all well and good until you run tests in docker (without extra sysctl) or in Travis-CI Linux where ipv6 is disabled. It should probably try 127.0.0.1 if ::1 fails to cover those cases.
@hjmallon hjmallon mentioned this issue Apr 26, 2019
Closed
facebook-github-bot pushed a commit that referenced this issue Nov 13, 2020
@hjmallon @facebook-github-bot
WIP: Fix Travis-CI builds (#193)
3573f1c 
Summary:
These changes fix Travis-CI builds on macOS and partially on Linux.

The only thing left to do on Linux is #192

This pull request also requires #188

Pull Request resolved: #193

Reviewed By: claudiozz

Differential Revision: D24933398

Pulled By: davide125

fbshipit-source-id: eb96db30a3cb71695111a7d41ca2c27fbe891d87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjmallon