Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android JSC Intl do not support signDisplay option #33428

Closed
retyui opened this issue Mar 15, 2022 · 8 comments
Closed

Android JSC Intl do not support signDisplay option #33428

retyui opened this issue Mar 15, 2022 · 8 comments
Labels
Needs: Triage 🔍 Platform: Android Android applications. Platform: Linux Building on Linux.

Comments

@retyui
Copy link
Contributor

retyui commented Mar 15, 2022

Description

I enabled JSC with Intl support:

// android/app/build.gradle
def jscFlavor = 'org.webkit:android-jsc-intl:+'

Then try to format currency with a signDisplay option

Intl.NumberFormat('en-US', {
        signDisplay: 'always',
        style: 'currency',
        currency: 'USD',
}).format(12) // $12.00

And result is $12.00 is incorrect !!! should be +$12.00

Deps:

yarn list jsc-android
└─ [email protected]
   └─ [email protected]

Version

0.66.x

Output of npx react-native info

System:
OS: Linux 5.4 Linux Mint 20.2 (Uma)
CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Memory: 169.38 MB / 15.46 GB
Shell: 3.4.0 - /usr/bin/fish
Binaries:
Node: 14.19.0 - /usr/bin/node
Yarn: 1.22.17 - /usr/bin/yarn
npm: 6.14.16 - /usr/bin/npm
Watchman: 20211205.130157.0 - /usr/local/bin/watchman
SDKs:
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Languages:
Java: 1.8.0_312 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 16.13.1
react-native: 0.66.4 => 0.66.4
npmGlobalPackages:
react-native: Not Found

Steps to reproduce

See description ....

Snack, code example, screenshot, or link to a repository

See description ....

@react-native-bot react-native-bot added Platform: Android Android applications. Platform: Linux Building on Linux. labels Mar 15, 2022
@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added Stale There has been a lack of activity on this issue and it may be closed soon. and removed Stale There has been a lack of activity on this issue and it may be closed soon. labels Sep 12, 2022
@retyui
Copy link
Contributor Author

retyui commented Nov 20, 2022

any progress ?

@cortinico
Copy link
Contributor

This is probably not the best repo for this issue @retyui
I believe you should close this issue and open it on https://github.com/react-native-community/jsc-android-buildscripts

@ghost
Copy link

ghost commented Nov 23, 2022

why? If react native used 2years old version of jsc-android
the issue in right place

@cortinico
Copy link
Contributor

Because that repo needs to be updated first, so it's the current blocker for React Native to update the JSC version.

@retyui
Copy link
Contributor Author

retyui commented Nov 28, 2022

npm history showing that a new pkg 294992.0.0 was released 4m ago, why React Native don't update JSC?

image

@cortinico
Copy link
Contributor

npm history showing that a new pkg 294992.0.0 was released 4m ago, why React Native don't update JSC?

React Native consumes JSC from react-native-community/jsc-android-buildscripts

So please open an issue on that repo first and get back here once a new version of jsc-android-buildscripts is available

@retyui
Copy link
Contributor Author

retyui commented Nov 28, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Platform: Android Android applications. Platform: Linux Building on Linux.
Projects
None yet
Development

No branches or pull requests

3 participants