From cef17ba14f435b966d2ffd9b3660ccf28fe03b6c Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Mon, 1 Jul 2024 03:32:14 -0700 Subject: [PATCH] Fix crash due to missing @JvmStatic to `convertToCase` Summary: Users are reporting that RN 0.75 is crashing due to us attempting to accessing a static method on `AndroidUnicodeUtils.convertToCase` which is not static anymore due to Kotlin conversion. Static access is inside Hermes codebase here: https://github.com/facebook/hermes/blob/f5c867514c71b25212eb3039230e0c095518b532/lib/Platform/Unicode/PlatformUnicodeJava.cpp#L107-L109 Changelog: [Android] [Fixed] - Fix crash due to missing JvmStatic to `convertToCase` Reviewed By: javache Differential Revision: D59218291 fbshipit-source-id: ac121a8bcd5fd917ee134d257f967c8e3e338ca5 --- .../main/java/com/facebook/hermes/unicode/AndroidUnicodeUtils.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/hermes/unicode/AndroidUnicodeUtils.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/hermes/unicode/AndroidUnicodeUtils.kt index 09d844461e4cd6..e784606489e8c7 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/hermes/unicode/AndroidUnicodeUtils.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/hermes/unicode/AndroidUnicodeUtils.kt @@ -39,6 +39,7 @@ public object AndroidUnicodeUtils { } @DoNotStrip + @JvmStatic public fun convertToCase(input: String, targetCase: Int, useCurrentLocale: Boolean): String { // Note Java's case conversions use the user's locale. For example "I".toLowerCase() // will produce a dotless i. From Java's docs: "To obtain correct results for locale