-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can the ccache build instructions be simplified? #4215
Comments
I'll defer to @cipolleschi here |
Hi @johnf, could you open a PR with the change? |
@cipolleschi Happy to! |
@johnf If the change has been introduced in 0.74, I think it's fine to just update |
@cipolleschi Thanks. I got confused. I was looking at an old branch I had, and the 0.75 and -0.74 directories didn't exist. PR ready at #4218 |
Description
https://reactnative.dev/docs/build-speed has detailed instructions for enabling ccace for xcode, I think this can be simplified
What is the problem?
The current instructions indicate the following code should be added to the Podfile
How can we address it?
I think this can be replace by uncommenting the
:ccache_enabled
argument toreact_native_post_install
e.g.
Why is it important?
RN now supports caching and from a quick look at the code does a better job at it. A pod update even recommends enabling ccache_enabled. So the docs aren't in line with the tooling.
Who needs this?
ios developers that want build peed improvements
When should this happen (use version numbers if needed)?
I would suggest updating the docs for all versions of RN that support the ccache_enabled flag
Other
I'd be happy to create a PR for the changes if the above is correct.
The text was updated successfully, but these errors were encountered: