Error message is undefined

[thierryjacoel]

I have tried to create a new AdAccount for my business, and I can see in the network panel of the browser devtools that I get an error with a message One or more of the ad accounts in your business manager are currently in bad standing or in review. All of your accounts must be in good standing in order to create or add new ad accounts.

However, when I try to display the error message to the user, the message is undefined.

I can see when I console log the FacebookRequestError that the message field is indeed undefined. When looking at the source, it seems that the generation of the Error object expects a name property on the object returned by Facebook, but it is not present (maybe a legacy thing).

Adding a general case in https://github.com/facebook/facebook-nodejs-ads-sdk/blob/master/src/exceptions.js#L68 would at least allow a non-conventional value for the name to not ignore the message returned.

[codytwinton]

It seems like this issue has been open for more than a few months now. We have made many changes in the SDK since then, including releasing a new version. If you can repro your specific issue with the latest version of the SDK, please create a new issue or comment here with further details.

[NovoManu]

Hi,
Error is still happens.

[codytwinton]

Ok, thanks for the heads up!

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

[NovoManu]

Didn't fixed yet

[bduffany]

Did some digging. The FacebookRequestError class here is expecting an object that looks like an error returned by the requestPromise API. But in the browser, XMLHttpRequest is used, not requestPromise. The structure of the error object is completely different (see the code here).

A possible fix could be to modify the Error returned by xmlHttpRequest to look "close enough" to the error returned by requestPromise.

[bduffany]

Any update on this? It makes the API very difficult to use on the client side, since we can't properly log errors.

EDIT: NVM, I just went ahead and fixed it. See #158

[stale]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

[bduffany]

Hi, the issue is still present and my PR is still open. #158