Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use native modal dialog and use its backdrop #10706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use native modal dialog and use its backdrop #10706

wants to merge 1 commit into from
+52 −20

Commits on Nov 21, 2024

  1. fix: use native modal dialog and use its backdrop 

    This uses the `<dialog>` element with `showModal()` method,
so that we can leverage the browser's built-in ways to make
this dialog modal, including keyboard handling (Esc), backdrop
and focus trap.

Fixes the issue that it was possible to tab outside the dialog
while it was open.

This removes the backdrop component, as the `<dialog>` element
comes with a backdrop built-in, that is styled via CSS instead.
    @hidde
    hidde committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dbee3b0 View commit details
    Browse the repository at this point in the history