fix(core): restore Rspack ProgressBar colors #10632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
changed the title
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +336 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +326 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adjust code so that Rspack compilation progress bars can have same colors as before.
Unfortunately, their underlying Rust lib indicatif doesn't have the exact same interface as webpackbar, but the
templateoption permits to restore former colors.See also https://rspack.dev/plugins/webpack/progress-plugin for available Rspack options.
Also there's a bug in Rspack integration of Indicatif: when using multiple compiler configs (client/server) the progress bars do not look that great and are somehow merged in a weird way.
This issue won't fix that problem, we need Rspack to use Indicatif MultiProgress in that case.
See also web-infra-dev/rspack#4214