Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upload changesets when an element in a relation whose type has a prefix is edited #1669

Open
Swarkin opened this issue Jan 5, 2025 · 1 comment
Labels
considering Not actionable: Still deciding if we want to add this. feature-validator Issue or request related to the validator

Comments

@Swarkin
Copy link

Swarkin commented Jan 5, 2025

Description

When editing an element in any way (even simply moving a node) that is a member of a relation which is tagged with for example disused:type=, both iD and Rapid refuse to upload it even though there have not been any edits to these relations as it doesn't detect the type field.

Screenshots

bkGV0tD

Version

2.5.0

What browser are you seeing the problem on? What version are you running?

Tested on Chromium and Firefox

The OS you're using

Windows 11

Steps to reproduce

  1. Find relation that has the (for example) disused:type tag
  2. Edit any element that is part of it

The browser URL at the time you encountered the bug

n/a

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

@bhousel bhousel added the feature-validator Issue or request related to the validator label Jan 7, 2025
@bhousel
Copy link
Contributor

bhousel commented Jan 7, 2025

related: openstreetmap/iD#10649
It sounds like there are ways to remove the type of a relation, or stumble upon one that has no type - which is invalid.

So the error you are seeing is a good error, but I'm not sure the best way to prompt a user to fix this. I agree it's a bit unfair to require a user to know about relations data model if they are just editing something unrelated.

@bhousel bhousel added the considering Not actionable: Still deciding if we want to add this. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not actionable: Still deciding if we want to add this. feature-validator Issue or request related to the validator
Projects
None yet
Development

No branches or pull requests

2 participants