Cannot deselect line or area draw tools

[diamondarmorsteve]

Description

After selecting the "line" or "area" drawing tools from the menu in the top-center of the screen, they cannot be deselected by clicking on them again, or by choosing another option. One must create a line/area before another option can be chosen. Hotkeys do not behave any differently.

Screenshots

No response

Version

2.5.0

What browser are you seeing the problem on? What version are you running?

Firefox v133

The OS you're using

Win11

Steps to reproduce

1. Click on either "Line" or "Area" in the top-center menu
2. Attempt to click it again, the button currently does not deselect
3. Try choosing another option, but the button does not respond (i.e. if "Line" was chosen, clicking "Point" or "Area" does nothing)

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#map=3.00/37.79/-13.97&background=Bing&datasets=fbRoads,msBuilding

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

[bhousel]

Hey @diamondarmorsteve , if I understand this issue correctly - I think this is an intentional design choice that we carried over from the iD code, which I added here: openstreetmap/iD#4042

We disable the buttons while the user is drawing because it was common for users to accidentally click up there, which could cancel the mode and remove all their drawn work. I think we can decide whether to keep this behavior or not - but in any case we should definitely style the buttons as disabled/greyed if we aren't doing this already.