Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove area=yes after polygon is tagged landuse=xxxx #1607

Open
jjiglesiasg opened this issue Nov 9, 2024 · 2 comments
Open

Remove area=yes after polygon is tagged landuse=xxxx #1607

jjiglesiasg opened this issue Nov 9, 2024 · 2 comments
Labels
considering Not actionable: Still deciding if we want to add this.

Comments

@jjiglesiasg
Copy link

jjiglesiasg commented Nov 9, 2024

Description

Normaly some area=yes polygon are created or modified for later be tagged with landuse=xxxx

if the Tag area=yes remains together with landuse=xxx the Q.A. tools and some validators mark that combination as a mapping mistake (error)

Would be nice to delete the area=yes tag automatically after using landuse=xxx tag so no error is injected in the Database

Thanks

@bhousel
Copy link
Contributor

bhousel commented Nov 14, 2024

Thanks for reporting this - I agree it's the expectation that the preset code should be already removing the extra area=yes tag.

@bhousel bhousel added the bug-regression It worked before but now it doesn't label Nov 14, 2024
@bhousel
Copy link
Contributor

bhousel commented Jan 13, 2025

I agree it's the expectation that the preset code should be already removing the extra area=yes tag

Oh, I think what's happening here is that

  • the Preset code does remove the area=yes tag,
  • but if a user changes tags manually in the raw tag editor, that component does not remove the area=yes tag
    (we assume that if the user is changing the tags this way, they can just add or remove the ones that they want.)

change preset (removes area=yes)

Image

change tags manually (keeps area=yes)

Image

In this case it's not really a bug like I thought?
I guess we probably could remove the area=yes at some other time, like before upload.

@bhousel bhousel added considering Not actionable: Still deciding if we want to add this. and removed bug-regression It worked before but now it doesn't labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not actionable: Still deciding if we want to add this.
Projects
None yet
Development

No branches or pull requests

2 participants