Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugins #143

Open
rawagner opened this issue Jan 19, 2018 · 4 comments
Open

Refactor plugins #143

rawagner opened this issue Jan 19, 2018 · 4 comments
Assignees
Labels

Comments

@rawagner
Copy link
Collaborator

I was just looking at the plugins and I wanted to ask you if you would mind to split the plugins as follows:

  1. com.redhat.fabric8analytics.eclipse.core - contains core stuff
  2. com.redhat.fabric8analytics.eclipse.ui - ui (stack analysis view)
  3. com.redhat.fabric8analytics.eclipse.lsp.core - LSP core stuff
  4. possibly in the future com.redhat.fabric8analytics.eclipse.lsp.ui

currently we have:

  1. com.redhat.fabric8analytics.lsp.eclipse.core - no need to have LSP in the name
  2. com.redhat.fabric8analytics.lsp.eclipse.ui - contains both analysis view & LSP funcionality.

I would be easier in the future, when the plugins gets bigger, to have Analysis View (or any other basic UI stuff) and LSP in different plugins

@geetikabatra WDYT ?

@geetikabatra
Copy link
Collaborator

@rawagner, Sounds good to me. It will make code base more cleaner. :)

@rawagner
Copy link
Collaborator Author

@geetikabatra awesome! :)

@rawagner rawagner self-assigned this Jan 22, 2018
@sivaavkd
Copy link

@geetikabatra is this complete ?

@geetikabatra
Copy link
Collaborator

@Siva, I am working on it. Need to make sure things don't break because of this as this involves a lot of code restructuring.

rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 10, 2018
rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 10, 2018
rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 10, 2018
rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 10, 2018
rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 12, 2018
rawagner added a commit to rawagner/fabric8-analytics-devstudio-plugin that referenced this issue Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants