Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information on (file) blueprint overrides #44

Open
CHE1RON opened this issue Mar 27, 2023 · 3 comments
Open

Add information on (file) blueprint overrides #44

CHE1RON opened this issue Mar 27, 2023 · 3 comments

Comments

@CHE1RON
Copy link
Contributor

CHE1RON commented Mar 27, 2023

Hey there,

as always: great plugin, I like it very much so far! One thing bothers me though: it's kind of hard to determine how to override blueprints that deal with files - this is interesting to me since I'm using custom upload folders, using query, parent and upload keys in my files fields / sections. How would I override the plugin's image fields (logo, og-image etc) and section (= file upload)? Looking at the (PHP) blueprints, I guess this isn't exactly straight-forward 😅

Thanks for considering this!

@CHE1RON
Copy link
Contributor Author

CHE1RON commented Mar 27, 2023

Just spotted this: I could do this

image:
  back: white

to prevent this

Screenshot 2023-03-27 at 10 28 49

(but one should not use transparent PNG logos, right 😁)

@fabianmichael
Copy link
Owner

@CHE1RON Sorry, the plugin was not designed to deal with custom folders. We could always add another option for doing that, but I am not sure if this affects enough users.

Just spotted this: I could do this

image:
  back: white

to prevent this

Screenshot 2023-03-27 at 10 28 49

(but one should not use transparent PNG logos, right 😁)

Please consider open a bug in the Kirby repo for updating the pattern … this has also caused a lot of trouble for me in other projects. Setting the background to white will will cause problems with very light images, so it is not really an option.

@CHE1RON
Copy link
Contributor Author

CHE1RON commented Mar 27, 2023

For me it would suffice for the README saying that meta-logo (or what's it called?), og-image and files section are loaded as meta/path/to/blueprint so one could override if needed, leaving customizations (if need be) to the users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants