-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to alternative languages, meta locale, OpenGraph locale #26
Comments
After reading some more docs, regarding the
|
@Daandelange Let’s omit the OpenGraph stuff then and just add the |
@Daandelange Thas already looks like a great start, thank you! :-) My only concern is, that most of the logic is contained within the snippet. I’d prefer to have all of that within the We also need to ensure, that we got the same implementation for generating the links in the Sitemap (see https://github.com/fabianmichael/kirby-meta/blob/main/src/Sitemap.php#L87-L97). Like I mentioned earlier, in some of my project I got additional options for disabling languages or translations of single pages in the panel. I also got a project, where translations of news articles are generated automatically by DeepL and just stored in the cache. On that project, the translated content does never exist, even if a translation of a page exists. Another example: Let’s say I got a page called "Blog", that does not have any content on it’s own. The title "Blog" works for many languages, so most translations of that page might never be created. TL;DR: Using I think having something like a |
Thanks for these explanations, didn't think about such scenarios. (in scenario 1 |
…ternates not yet shared)
Hey, I'm almost there but there's a choice to make first. How to access/share Also, I've rather opted for |
Does anything speak against accessing I like the idea of defining the method in more abstract form, so it could easily be used in different scenarios. |
E.g.
See
There needs to be an API/hook to filter out incomplete versions of secondary languages, so they can also be removed from the XML sitemap.
The text was updated successfully, but these errors were encountered: