Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine virtual server dashboard #57

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Combine virtual server dashboard #57

merged 11 commits into from
Nov 14, 2024

Conversation

c1ly
Copy link
Collaborator

@c1ly c1ly commented Nov 12, 2024

No description provided.

clhain and others added 10 commits October 10, 2024 16:31
@clhain
Merge pull request f5devcentral#20 from f5devcentral/development
3705c46 
Development
@clhain
Merge pull request f5devcentral#22 from f5devcentral/development
45c164c 
Update page deploy action with build steps and fix dashboard import bug
@clhain
Merge pull request f5devcentral#24 from f5devcentral/development
0758eab 
Documentation site fixes
@c1ly
Merge pull request f5devcentral#40 from f5devcentral/development
73e2a4a 
Release 0.7.0
@c1ly
Merge pull request f5devcentral#42 from f5devcentral/development
4e994a1 
Fix pages workflow
@clhain
Merge pull request f5devcentral#46 from f5devcentral/development
f6191d6 
Add link checking for sites pages
@mikempw
Merge pull request f5devcentral#50 from f5devcentral/development
e6189f9 
Fix documentation url paths
@mikempw
Merge pull request f5devcentral#54 from f5devcentral/development
0c30ba5 
Update readme links
@mikempw
Merge pull request f5devcentral#56 from f5devcentral/development
9cee7cd 
Fix additional broken migration link
@c1ly
simplify to only one virtual server dashboard at the device level
12fe4ad
@c1ly c1ly requested a review from a team as a code owner November 12, 2024 21:13
@clhain
Copy link
Collaborator

clhain commented Nov 13, 2024

Looks good, few small things:

General:

  • Re-save with the Summary and Availability drop-downs expanded

Stuff to prevent wonky upgrades / imports:

  • Use the existing ID for the Virtual Server Overview dashboard (think just edit the file after you export it to use UID ddq2jbj2v588wa)
  • Use the next version (22)
  • When exporting to json, do it via "Share -> Export -> Enable: Export For Sharing Globally"

clhain
clhain approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@clhain clhain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@c1ly c1ly merged commit f99d3e4 into f5devcentral:development Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clhain clhain clhain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c1ly @clhain @mikempw