Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotator Controller manual entry box up-down buttons for azimuth and elevation offsets are not precision-aware #1771

Closed
lrowen opened this issue Aug 9, 2023 · 4 comments

Comments

@lrowen
Copy link
Contributor

lrowen commented Aug 9, 2023

The manual up-down controls for the azimuth and elevation offsets change the value by integer degrees. The change should probably track the precision of the offsets. I've tried selecting portions of the number to change, but the up-down only changes the integer degrees.

@srcejon
Copy link
Collaborator

srcejon commented Aug 9, 2023

In GS232ControllerGUI::setPrecision you could try appending:

double step = pow(10.0, -m_settings.m_precision);
ui->coord1->setSingleStep(step);
ui->coord2->setSingleStep(step);
ui->tolerance->setSingleStep(step);
ui->azimuthOffset->setSingleStep(step);
ui->elevationOffset->setSingleStep(step);

@lrowen
Copy link
Contributor Author

lrowen commented Aug 9, 2023

That works.

EDIT: I committed to a branch in my fork.

@lrowen
Copy link
Contributor Author

lrowen commented Aug 10, 2023

PR #1775 implements this change with the code provided by srcejon above, tested here.

@srcejon
Copy link
Collaborator

srcejon commented Aug 23, 2023

Implemented in 7.15.3

@srcejon srcejon closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants