Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeve1
approved these changes
Oct 30, 2024
| MethodArgumentNotValidException.class | ||
| }) | ||
| public ResponseEntity<ValidationResponse> handleValidationExceptions(MethodArgumentNotValidException ex) { | ||
| AtomicInteger i = new AtomicInteger(1); |
There was a problem hiding this comment.
이 부분도 수정하겠습니다! #111
| import org.springframework.validation.annotation.Validated; | ||
| import org.springframework.web.bind.annotation.*; | ||
|
|
||
| @Controller |
There was a problem hiding this comment.
오.. @RestController가 아닌데도 아래 registerProgress 응답이 제대로 오나요?
@responsebody 를 추가해주거나 @RestController로 해야 json 응답이 내려갈 것 같아서요(그냥 Controller는 html 리소스를 리턴하므로)
There was a problem hiding this comment.
이것도 수정하고 있습니다..!
|
|
||
| private static String APPROVED = "요청자에 의해 인증이 승인 되었습니다."; | ||
|
|
||
| @PostMapping("/approved") |
There was a problem hiding this comment.
approved는 과거형이므로 restAPI uri로 보기엔 애매한 부분이 있습니다. 이 api를 호출할 당시엔 아직 승인되지 않은 상태니까요!
There was a problem hiding this comment.
음.. 저번에 HTTP URI 규칙에 관해서 링크를 주셨었는데 제가 제대로 숙지를 못한 것 같습니다. 이 부분 변경하겠습니다. #46
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
진행관련 기능들