Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

13주차 PR 질문 모음 #39

Closed
ScottSung7 opened this issue Aug 18, 2024 · 8 comments
Closed

13주차 PR 질문 모음 #39

ScottSung7 opened this issue Aug 18, 2024 · 8 comments
Assignees
@ScottSung7

Comments

@ScottSung7
Copy link
Collaborator

ScottSung7 commented Aug 18, 2024 •
edited
Loading

PR 관련 질문들을 보기 쉽도록 모아 보았습니다.
@ScottSung7 ScottSung7 self-assigned this Aug 18, 2024
@ScottSung7 ScottSung7 mentioned this issue Aug 18, 2024
Merged
@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q1. Etc 엔터티의 책임 범위.

링크 : #34 (comment)

@ScottSung7 ScottSung7 mentioned this issue Aug 18, 2024
Merged
@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q2. @tx가 붙은 테스트와 안 붙은 테스트

링크 : #33 (comment)

@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q3. 묶여있는 메소드와 아닌 메소드의 차이

링크: #33 (comment)

@ScottSung7 ScottSung7 mentioned this issue Aug 18, 2024
Merged
@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q4. rest API 관련해서 어떤 것을 보강 해야 할까요?

링크: #32 (comment)

@ScottSung7
Copy link
Collaborator Author

Q5. nested class 사용 방법

링크: #32 (comment)

@ScottSung7
Copy link
Collaborator Author

Request 1: 예외 테스트의 방법에 문제가 없을지 확인 부탁드립니다~! (아마 새로운 커밋에는 모두 예외 테스트가 같이 들어와 있습니다.)

링크: #32 (comment)

@ScottSung7 ScottSung7 mentioned this issue Aug 18, 2024
Merged
@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q6. Infra에서 발생된 예외의 실용적 활용 방법.

링크: #31 (comment)
관련 이슈: #22

@ScottSung7
Copy link
Collaborator Author

ScottSung7 commented Aug 18, 2024 •
edited
Loading

Q7. 불완전 객체와 약한 객체 문제.

이 부분은 Hotfix에서 fixme로 새로 질문하였습니다.

Hotfix 01: #35 (comment)
링크1 : #31 (comment)
링크2 : #31 (comment)
관련 이슈: #28

@ScottSung7 ScottSung7 changed the title PR 질문 모음 13주차 PR 질문 모음 Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScottSung7 ScottSung7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ScottSung7