Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative symlinks for assets:install command #437

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emodric
Copy link
Contributor

@emodric emodric commented Jul 23, 2019

No description provided.

@andrerom
Copy link
Contributor

andrerom commented Jul 30, 2019

Or do we want to re-add the config from earlier branches?

"symfony-assets-install": "relative",

@emodric
Copy link
Contributor Author

emodric commented Jul 30, 2019

Does that still work?

If it does, it would be better, to prevent Symfony recipes overwriting the command in auto-scripts.

@emodric
Copy link
Contributor Author

emodric commented Jul 30, 2019

Tried it, it doesn't work.

@andrerom
Copy link
Contributor

What about us asking them to re-add support for that?

But that said, I guess it won't help once we move to full symfony flex over meta repo.

@emodric
Copy link
Contributor Author

emodric commented Jul 30, 2019

What about us asking them to re-add support for that?

They actually removed it before due to it not working on some setups: symfony/recipes#406

But that said, I guess it won't help once we move to full symfony flex over meta repo.

Not sure what you mean?

@emodric
Copy link
Contributor Author

emodric commented Jul 30, 2019

I'm not sure what would be the best course of action here. This patch has an effect of default version of assets:install being readded to auto-scripts as described in symfony/recipes#631. It would require symfony.lock to be present to prevent it from happening (hence my other PR)

@andrerom andrerom added the 3.x label Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants