Fix non avx2 #61
Merged
Fix non avx2 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ended up being the root cause of #60. Most of this change is refactoring to ensure that all available implementations run during testing, not just AVX2. That'll ensure we can avoid regressions in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the core bug pointed out in #60, though part of the ensuing discussion on that issue has pointed out to me that frawk does not have great support for people with CPUs that do not support AVX. This change will fix bugs that show up when those folks build from source on such a machine, but there's more work to do before we can reliably ship binary releases that will work on any (say, post-SSE2) x86-64 machine.