Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeFormatter should use T: ?Sized + fmt::Write instead of T: fmt::Write #16

Open
thomcc opened this issue Aug 4, 2021 · 0 comments
Open

CodeFormatter should use T: ?Sized + fmt::Write instead of T: fmt::Write #16

thomcc opened this issue Aug 4, 2021 · 0 comments
Assignees
@ten3roberts

Comments

@thomcc
Copy link

thomcc commented Aug 4, 2021 •
edited
Loading

That way CodeFormatter<'a, dyn fmt::Write> is usable. This is trivial (bounds just need to gain : ?Sized), non-breaking, and has no real downsides AFAICT.

The only reason this is an issue and not a PR is that it would have a merge conflict with #15, so I'll wait for that one to resolve either way first rather than having a mid-air collision with myself.
@thomcc thomcc changed the title CodeFormatter should use T: ?Sized for the fmt::Write CodeFormatter should use T: ?Sized + fmt::Write instead of T: fmt::Write Aug 4, 2021
@AstrickHarren AstrickHarren mentioned this issue Jan 23, 2024
Open
@ten3roberts ten3roberts self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ten3roberts ten3roberts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomcc @ten3roberts