Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly strict clippy lint #172

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix overly strict clippy lint #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ jobs:
- uses: actions-rs/cargo@v1
with:
command: clippy
args: --all-targets --all-features -- -D warnings

args: --all-targets --all-features -- -D clippy::style -D clippy::suspiscious -D clippy::complexity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of doing it like this, it might be worth changing the stable to an MSRV.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, pinning the clippy version

Only danger with that is that we may not update it for a while and not get new "good to deny by default" lints.

This primarily solves the overly pedantic lints, while still giving us all the new ones as warnings.

Both are good

Maybe a combination?

Sticking to latest also makes it easier to run clippy locally, as you don't have to track which version, especially for new contributors who aren't aware of it, not understanding why there are different results.

But that is just a minor thing.

miri:
name: Miri
runs-on: ubuntu-latest
Expand Down
Loading