Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Allow attaching Reports to Reports #208

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

afmireski
Copy link

Implemented a way to properly link additional color_eyre::Reports to a Report: report and with_report.

  • All existing tests passed
  • Documentation for new methods added
  • Usage examples provided

closes #198

* Define help_info_report styles for Theme in src/config.rs (Similar to
help_info_error style)

* Implement Display and Debug formatters for HelpInfo::Report
- Added doc comments for both methods
- Added two examples for demonstrate methods usage in /examples:
multiple_reports_lazy.rs and multiple_reports
@afmireski
Copy link
Author

Accepted suggestions from cargo fmt and cargo clippy to fix the CI errors related to rustfmt and clippy.

  • All existing tests passed

@afmireski
Copy link
Author

afmireski commented Nov 22, 2024

Regarding the macOS-latest CI failure, I believe updating the pyo3 crate to a more recent version that supports Python 3.13 might resolve the issue.
image

Since version 22.0, pyo3 seems to be adding support for Python 3.13.
However, I consider upgrading package versions a critical decision that shouldn't be made alone.

My proposal is to update the eyre Cargo.toml as follows:

[dependencies]
...
pyo3 = { version = "0.23.1", optional = true, default-features = false }
...

[dev-dependencies]
...
pyo3 = { version = "0.23.1", default-features = false, features = ["auto-initialize"] }

@yaahc, would this be a valid approach? I'm open to any suggestions or feedback.

@yaahc
Copy link
Collaborator

yaahc commented Nov 22, 2024

tenatively that sounds fine, the only concern would be whats the MSRV for that version of pyo3 since we'd inherit it

@afmireski
Copy link
Author

Looking at the release history of the pyo3 crate, the current version being used (0.20) has a MSRV of 1.56.0. Starting from version 0.22.0, the MSRV was raised to 1.63.0.
Is it okay if I proceed with the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Allow attaching Reports to Reports
2 participants